diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/footer/UploadViewConfirmationWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/footer/UploadViewConfirmationWindowLayout.java index 28f760583..267f14c3a 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/footer/UploadViewConfirmationWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/footer/UploadViewConfirmationWindowLayout.java @@ -54,7 +54,7 @@ public class UploadViewConfirmationWindowLayout extends AbstractConfirmationWind private final ArtifactUploadState artifactUploadState; - public UploadViewConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus, + UploadViewConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus, final SoftwareManagement softwareManagement, final ArtifactUploadState artifactUploadState) { super(i18n, eventBus); this.softwareManagement = softwareManagement; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleDetails.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleDetails.java index 4fd194926..5960b44f6 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleDetails.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleDetails.java @@ -36,8 +36,6 @@ import com.vaadin.ui.Window; /** * Software module details. - * - * */ public class SoftwareModuleDetails extends AbstractNamedVersionedEntityTableDetailsLayout { @@ -53,8 +51,7 @@ public class SoftwareModuleDetails extends AbstractNamedVersionedEntityTableDeta private final SoftwareModuleMetadatadetailslayout swmMetadataTable; - public SoftwareModuleDetails(final I18N i18n, final UIEventBus eventBus, - final SpPermissionChecker permissionChecker, + SoftwareModuleDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker, final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow, final ArtifactUploadState artifactUploadState, final SoftwareManagement softwareManagement, final SwMetadataPopupLayout swMetadataPopupLayout, final EntityFactory entityFactory) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTable.java index 57fa5a65a..4221b0301 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTable.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTable.java @@ -65,7 +65,7 @@ public class SoftwareModuleTable extends AbstractNamedVersionTable uploadResultList, final I18N i18n) { + UploadResultWindow(final List uploadResultList, final I18N i18n) { this.uploadResultList = uploadResultList; this.i18n = i18n; eventBus = SpringContextHelper.getBean(EventBus.UIEventBus.class); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusInfoWindow.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusInfoWindow.java index 7b4aebc44..0d3e9e989 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusInfoWindow.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusInfoWindow.java @@ -93,8 +93,7 @@ public class UploadStatusInfoWindow extends Window { private ConfirmationDialog confirmDialog; - public UploadStatusInfoWindow(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState, - final I18N i18n) { + UploadStatusInfoWindow(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState, final I18N i18n) { this.eventBus = eventBus; this.artifactUploadState = artifactUploadState; this.i18n = i18n; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusObject.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusObject.java index eec189eaf..82e003be8 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusObject.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/UploadStatusObject.java @@ -27,15 +27,7 @@ public class UploadStatusObject implements Serializable { private String reason; private final SoftwareModule selectedSoftwareModule; - public UploadStatusObject(final String status, final Double progress, final String fileName, final String reason, - final SoftwareModule selectedSoftwareModule) { - this(fileName, selectedSoftwareModule); - this.status = status; - this.progress = progress; - this.reason = reason; - } - - public UploadStatusObject(final String fileName, final SoftwareModule selectedSoftwareModule) { + UploadStatusObject(final String fileName, final SoftwareModule selectedSoftwareModule) { this.filename = fileName; this.selectedSoftwareModule = selectedSoftwareModule; } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/colorpicker/ColorPickerLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/colorpicker/ColorPickerLayout.java index e748a4072..29c8c1ff9 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/colorpicker/ColorPickerLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/colorpicker/ColorPickerLayout.java @@ -62,7 +62,7 @@ public class ColorPickerLayout extends GridLayout { addComponent(colorSelect, 1, 1, 1, 3); } - public void init() { + private void init() { selectors = new HashSet<>(); selectedColor = getDefaultColor(); @@ -80,7 +80,7 @@ public class ColorPickerLayout extends GridLayout { selectors.add(colorSelect); } - public Slider createRGBSlider(final String caption, final String styleName) { + private Slider createRGBSlider(final String caption, final String styleName) { final Slider slider = new Slider(caption, 0, 255); slider.setImmediate(true); slider.setWidth("150px"); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/DistributionSetInfoPanel.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/DistributionSetInfoPanel.java index d3dd5b63d..ea02b6128 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/DistributionSetInfoPanel.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/DistributionSetInfoPanel.java @@ -19,9 +19,6 @@ import com.vaadin.ui.VerticalLayout; /** * Distribution set panel for Target. - * - * - * */ @SuppressWarnings("serial") public class DistributionSetInfoPanel extends Panel { @@ -38,9 +35,8 @@ public class DistributionSetInfoPanel extends Panel { * @param style2 * as String */ - public DistributionSetInfoPanel(final DistributionSet distributionSet, final String caption, final String style1, + DistributionSetInfoPanel(final DistributionSet distributionSet, final String caption, final String style1, final String style2) { - super(); setImmediate(false); decorate(distributionSet, caption, style1, style2); } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPTargetAttributesLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPTargetAttributesLayout.java index fc363acf8..cb45ca2d9 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPTargetAttributesLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPTargetAttributesLayout.java @@ -21,9 +21,6 @@ import com.vaadin.ui.VerticalLayout; /** * Attributes Vertical layout for Target. - * - * - * */ public class SPTargetAttributesLayout { private final VerticalLayout targetAttributesLayout; @@ -35,7 +32,7 @@ public class SPTargetAttributesLayout { * controller attributes * */ - public SPTargetAttributesLayout(final Map controllerAttibs) { + SPTargetAttributesLayout(final Map controllerAttibs) { targetAttributesLayout = new VerticalLayout(); targetAttributesLayout.setSpacing(true); targetAttributesLayout.setMargin(true); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUIButton.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUIButton.java index 2dfdad723..7f19bb5f2 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUIButton.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUIButton.java @@ -13,29 +13,11 @@ import com.vaadin.ui.Button; /** * Basic button for SPUI. Any commonality can be decorated. - * - * - * */ - public class SPUIButton extends Button { - - /** - * ID. - */ private static final long serialVersionUID = -7327726430436273739L; - /** - * Parametric constructor. - * - * @param id - * as String - * @param buttonName - * as String - * @param buttonDesc - * as String - */ - public SPUIButton(final String id, final String buttonName, final String buttonDesc) { + SPUIButton(final String id, final String buttonName, final String buttonDesc) { super(buttonName); setDescription(buttonDesc); setImmediate(false); @@ -50,7 +32,7 @@ public class SPUIButton extends Button { * @param icon * as Resource */ - public void togleIcon(Resource icon) { + public void togleIcon(final Resource icon) { setIcon(icon); } } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUICheckBox.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUICheckBox.java index 753cafa7f..f75a03cd7 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUICheckBox.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/components/SPUICheckBox.java @@ -13,32 +13,13 @@ import com.vaadin.ui.themes.ValoTheme; /** * ComboBox with required style. - * - * - * */ public class SPUICheckBox extends CheckBox { private static final long serialVersionUID = 2270323611612189225L; - /** - * Parametric constructor to decorate. - * - * @param caption - * as caption for checkbox - * @param style - * style of the CheckBox - * @param styleName - * styleName of the CheckBox - * @param required - * required check for Checkbox - * @param data - * data of the CheckBox - * - */ - public SPUICheckBox(final String caption, final String style, final String styleName, final boolean required, + SPUICheckBox(final String caption, final String style, final String styleName, final boolean required, final String data) { - super(); decorate(caption, style, styleName, required, data); } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtonClick.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtonClick.java index 8dbe2a2f9..ef96a68f1 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtonClick.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtonClick.java @@ -33,7 +33,7 @@ public class DSTypeFilterButtonClick extends AbstractFilterSingleButtonClick imp private final DistributionSetManagement distributionSetManagement; - public DSTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState, + DSTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState, final DistributionSetManagement distributionSetManagement) { this.eventBus = eventBus; this.manageDistUIState = manageDistUIState; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtons.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtons.java index 50e6ac22c..5c380f43c 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtons.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterButtons.java @@ -39,7 +39,7 @@ public class DSTypeFilterButtons extends AbstractFilterButtons { private final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria; - public DSTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState, + DSTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState, final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria, final DistributionSetManagement distributionSetManagement) { super(eventBus, new DSTypeFilterButtonClick(eventBus, manageDistUIState, distributionSetManagement)); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterHeader.java index 1bc3ec631..7aa464fda 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/DSTypeFilterHeader.java @@ -37,7 +37,7 @@ public class DSTypeFilterHeader extends AbstractFilterHeader { private final CreateUpdateDistSetTypeLayout createUpdateDistSetTypeLayout; - public DSTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus, + DSTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus, final ManageDistUIState manageDistUIState, final TagManagement tagManagement, final EntityFactory entityFactory, final UINotification uiNotification, final SoftwareManagement softwareManagement, final DistributionSetManagement distributionSetManagement) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetDetails.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetDetails.java index 5fcd9346a..2bfaf4753 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetDetails.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetDetails.java @@ -71,16 +71,14 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet private final DistributionTagToken distributionTagToken; - private final SoftwareManagement softwareManagement; + private final transient SoftwareManagement softwareManagement; - private final DistributionSetManagement distributionSetManagement; + private final transient DistributionSetManagement distributionSetManagement; - private final TargetManagement targetManagement; + private final transient TargetManagement targetManagement; private final DsMetadataPopupLayout dsMetadataPopupLayout; - private final EntityFactory entityFactory; - private final SoftwareModuleDetailsTable softwareModuleTable; private final DistributionSetMetadatadetailslayout dsMetadataTable; @@ -91,9 +89,8 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet private Map assignedSWModule; - public DistributionSetDetails(final I18N i18n, final UIEventBus eventBus, - final SpPermissionChecker permissionChecker, final ManageDistUIState manageDistUIState, - final ManagementUIState managementUIState, + DistributionSetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker, + final ManageDistUIState manageDistUIState, final ManagementUIState managementUIState, final DistributionAddUpdateWindowLayout distributionAddUpdateWindowLayout, final SoftwareManagement softwareManagement, final DistributionSetManagement distributionSetManagement, final TargetManagement targetManagement, final EntityFactory entityFactory, @@ -108,7 +105,6 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet this.distributionSetManagement = distributionSetManagement; this.targetManagement = targetManagement; this.dsMetadataPopupLayout = popupLayout; - this.entityFactory = entityFactory; softwareModuleTable = new SoftwareModuleDetailsTable(i18n, true, permissionChecker, distributionSetManagement, eventBus, manageDistUIState); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java index bc424dbac..d2ba963eb 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java @@ -98,7 +98,7 @@ public class DistributionSetTable extends AbstractNamedVersionTable { private VerticalLayout assignedDistLayout; private VerticalLayout installedDistLayout; - public TargetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker, + TargetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker, final ManagementUIState managementUIState, final UINotification uiNotification, final TagManagement tagManagement, final TargetManagement targetManagement, final EntityFactory entityFactory) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTableHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTableHeader.java index fa2e58e42..7e500b257 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTableHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTableHeader.java @@ -71,7 +71,7 @@ public class TargetTableHeader extends AbstractTableHeader { private boolean isComplexFilterViewDisplayed; - public TargetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus, + TargetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus, final UINotification notification, final ManagementUIState managementUIState, final ManagementViewAcceptCriteria managementViewAcceptCriteria, final TargetManagement targetManagement, final DeploymentManagement deploymentManagement, final UiProperties uiproperties, final UIEventBus eventBus, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/FilterByStatusLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/FilterByStatusLayout.java index e00f5183b..42ea4d424 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/FilterByStatusLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/FilterByStatusLayout.java @@ -61,7 +61,7 @@ public class FilterByStatusLayout extends VerticalLayout implements Button.Click private Button buttonClicked; private static final String BTN_CLICKED = "btnClicked"; - public FilterByStatusLayout(final I18N i18n, final UIEventBus eventBus, final ManagementUIState managementUIState) { + FilterByStatusLayout(final I18N i18n, final UIEventBus eventBus, final ManagementUIState managementUIState) { this.i18n = i18n; this.eventBus = eventBus; this.managementUIState = managementUIState; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/MultipleTargetFilter.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/MultipleTargetFilter.java index 267098603..8c8315f40 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/MultipleTargetFilter.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/MultipleTargetFilter.java @@ -56,7 +56,7 @@ public class MultipleTargetFilter extends Accordion implements SelectedTabChange private Button config; - public MultipleTargetFilter(final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout, + MultipleTargetFilter(final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout, final SpPermissionChecker permChecker, final ManagementUIState managementUIState, final I18N i18n, final UIEventBus eventBus, final ManagementViewAcceptCriteria managementViewAcceptCriteria, final UINotification notification, final EntityFactory entityFactory, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetFilterQueryButtons.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetFilterQueryButtons.java index 5058d78ae..72584c9b6 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetFilterQueryButtons.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetFilterQueryButtons.java @@ -46,7 +46,7 @@ public class TargetFilterQueryButtons extends Table { private CustomTargetTagFilterButtonClick customTargetTagFilterButtonClick; - public TargetFilterQueryButtons(final ManagementUIState managementUIState, final UIEventBus eventBus) { + TargetFilterQueryButtons(final ManagementUIState managementUIState, final UIEventBus eventBus) { this.managementUIState = managementUIState; this.eventBus = eventBus; } @@ -56,7 +56,7 @@ public class TargetFilterQueryButtons extends Table { * * @param filterButtonClickBehaviour */ - public void init(final CustomTargetTagFilterButtonClick filterButtonClickBehaviour) { + void init(final CustomTargetTagFilterButtonClick filterButtonClickBehaviour) { this.customTargetTagFilterButtonClick = filterButtonClickBehaviour; createTable(); eventBus.subscribe(this); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtonClick.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtonClick.java index f1d883842..cd08b1c9f 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtonClick.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtonClick.java @@ -31,7 +31,7 @@ public class TargetTagFilterButtonClick extends AbstractFilterMultiButtonClick i private final ManagementUIState managementUIState; - public TargetTagFilterButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) { + TargetTagFilterButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) { this.eventBus = eventBus; this.managementUIState = managementUIState; } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtons.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtons.java index 20d68ed55..610bc4472 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtons.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterButtons.java @@ -73,7 +73,7 @@ public class TargetTagFilterButtons extends AbstractFilterButtons { private final TargetManagement targetManagement; - public TargetTagFilterButtons(final UIEventBus eventBus, final ManagementUIState managementUIState, + TargetTagFilterButtons(final UIEventBus eventBus, final ManagementUIState managementUIState, final ManagementViewAcceptCriteria managementViewAcceptCriteria, final I18N i18n, final UINotification notification, final SpPermissionChecker permChecker, final EntityFactory entityFactory, final TargetManagement targetManagement) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterHeader.java index da8a1482f..e579b3372 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/TargetTagFilterHeader.java @@ -26,14 +26,12 @@ public class TargetTagFilterHeader extends AbstractFilterHeader { private static final long serialVersionUID = 3046367045669148009L; private final ManagementUIState managementUIState; - private final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout; - public TargetTagFilterHeader(final I18N i18n, final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout, + TargetTagFilterHeader(final I18N i18n, final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout, final ManagementUIState managementUIState, final SpPermissionChecker permChecker, final UIEventBus eventBus) { super(permChecker, eventBus, i18n); this.managementUIState = managementUIState; - this.createUpdateTargetTagLayout = createUpdateTargetTagLayout; if (permChecker.hasCreateTargetPermission() || permChecker.hasUpdateTargetPermission()) { createUpdateTargetTagLayout.init(); } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/menu/GravatarResource.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/menu/GravatarResource.java index 6971ea6b4..20fd85808 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/menu/GravatarResource.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/menu/GravatarResource.java @@ -24,14 +24,14 @@ public class GravatarResource extends ExternalResource { /** * Construct based on given email address. Generates external resource - * pointing to gravatar with rating - * "g: suitable for display on all websites with any audience type." and - * "mystery-man" icon as backup as secure request. + * pointing to gravatar with rating "g: suitable for display on all websites + * with any audience type." and "mystery-man" icon as backup as secure + * request. * * @param email * to generate resource for */ - public GravatarResource(final String email) { + GravatarResource(final String email) { super("https://www.gravatar.com/avatar/" + DigestUtils.md5DigestAsHex(email.getBytes()) + ".jpg?s=56&r=g&d=mm"); } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/StatusFontIcon.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/StatusFontIcon.java index 9ab22a6b1..cfd1e63dd 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/StatusFontIcon.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/StatusFontIcon.java @@ -25,7 +25,7 @@ public class StatusFontIcon { final FontAwesome fontIcon; final String style; - public StatusFontIcon(FontAwesome fontIcon, String style) { + public StatusFontIcon(final FontAwesome fontIcon, final String style) { super(); this.fontIcon = fontIcon; this.style = style; @@ -39,4 +39,4 @@ public class StatusFontIcon { return style; } -} \ No newline at end of file +} diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/AddUpdateRolloutWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/AddUpdateRolloutWindowLayout.java index c2821a57f..7cd6e6481 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/AddUpdateRolloutWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/AddUpdateRolloutWindowLayout.java @@ -128,10 +128,9 @@ public class AddUpdateRolloutWindowLayout extends GridLayout { private final NullValidator nullValidator = new NullValidator(null, false); - public AddUpdateRolloutWindowLayout(final RolloutManagement rolloutManagement, - final TargetManagement targetManagement, final UINotification uiNotification, - final UiProperties uiProperties, final EntityFactory entityFactory, final I18N i18n, - final UIEventBus eventBus) { + AddUpdateRolloutWindowLayout(final RolloutManagement rolloutManagement, final TargetManagement targetManagement, + final UINotification uiNotification, final UiProperties uiProperties, final EntityFactory entityFactory, + final I18N i18n, final UIEventBus eventBus) { this.actionTypeOptionGroupLayout = new ActionTypeOptionGroupLayout(i18n); this.rolloutManagement = rolloutManagement; this.targetManagement = targetManagement; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListGrid.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListGrid.java index 3fe5ff862..e991af6fa 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListGrid.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListGrid.java @@ -127,7 +127,7 @@ public class RolloutListGrid extends AbstractGrid { new StatusFontIcon(FontAwesome.EXCLAMATION_CIRCLE, SPUIStyleDefinitions.STATUS_ICON_RED)); } - public RolloutListGrid(final I18N i18n, final UIEventBus eventBus, final RolloutManagement rolloutManagement, + RolloutListGrid(final I18N i18n, final UIEventBus eventBus, final RolloutManagement rolloutManagement, final UINotification uiNotification, final RolloutUIState rolloutUIState, final SpPermissionChecker permissionChecker, final TargetManagement targetManagement, final EntityFactory entityFactory, final UiProperties uiProperties) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListHeader.java index 3978da017..074452c43 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/RolloutListHeader.java @@ -40,7 +40,7 @@ public class RolloutListHeader extends AbstractGridHeader { private final AddUpdateRolloutWindowLayout addUpdateRolloutWindow; - public RolloutListHeader(final SpPermissionChecker permissionChecker, final RolloutUIState rolloutUIState, + RolloutListHeader(final SpPermissionChecker permissionChecker, final RolloutUIState rolloutUIState, final UIEventBus eventBus, final RolloutManagement rolloutManagement, final TargetManagement targetManagement, final UINotification uiNotification, final UiProperties uiProperties, final EntityFactory entityFactory, final I18N i18n) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/AuthenticationConfigurationView.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/AuthenticationConfigurationView.java index 676a499ce..fbeac2502 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/AuthenticationConfigurationView.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/AuthenticationConfigurationView.java @@ -55,8 +55,7 @@ public class AuthenticationConfigurationView extends BaseConfigurationView private CheckBox downloadAnonymousCheckBox; - public AuthenticationConfigurationView(final I18N i18n, - final TenantConfigurationManagement tenantConfigurationManagement, + AuthenticationConfigurationView(final I18N i18n, final TenantConfigurationManagement tenantConfigurationManagement, final SecurityTokenGenerator securityTokenGenerator) { this.i18n = i18n; this.certificateAuthenticationConfigurationItem = new CertificateAuthenticationConfigurationItem( diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/DefaultDistributionSetTypeLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/DefaultDistributionSetTypeLayout.java index c3753e1a7..d435f74c6 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/DefaultDistributionSetTypeLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/DefaultDistributionSetTypeLayout.java @@ -33,11 +33,7 @@ public class DefaultDistributionSetTypeLayout extends BaseConfigurationView impl private static final long serialVersionUID = 17896542758L; - private final SystemManagement systemManagement; - - private final DistributionSetManagement distributionSetManagement; - - private final I18N i18n; + private final transient SystemManagement systemManagement; private Long currentDefaultDisSetType; @@ -49,11 +45,9 @@ public class DefaultDistributionSetTypeLayout extends BaseConfigurationView impl private final Label changeIcon; - public DefaultDistributionSetTypeLayout(final SystemManagement systemManagement, + DefaultDistributionSetTypeLayout(final SystemManagement systemManagement, final DistributionSetManagement distributionSetManagement, final I18N i18n) { this.systemManagement = systemManagement; - this.distributionSetManagement = distributionSetManagement; - this.i18n = i18n; final Panel rootPanel = new Panel(); rootPanel.setSizeFull(); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/PollingConfigurationView.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/PollingConfigurationView.java index 2c55f2c8f..ee00568ad 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/PollingConfigurationView.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/PollingConfigurationView.java @@ -38,7 +38,7 @@ public class PollingConfigurationView extends BaseConfigurationView private Duration tenantPollTime; private Duration tenantOverdueTime; - public PollingConfigurationView(final I18N i18n, final ControllerPollProperties controllerPollProperties, + PollingConfigurationView(final I18N i18n, final ControllerPollProperties controllerPollProperties, final TenantConfigurationManagement tenantConfigurationManagement) { this.tenantConfigurationManagement = tenantConfigurationManagement; @@ -130,7 +130,7 @@ public class PollingConfigurationView extends BaseConfigurationView notifyConfigurationChanged(); } - private boolean compareDurations(final Duration d1, final Duration d2) { + private static boolean compareDurations(final Duration d1, final Duration d2) { if (d1 == null && d2 == null) { return true; } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/SPDateTimeUtil.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/SPDateTimeUtil.java index df8cf27d6..1d1687dda 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/SPDateTimeUtil.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/SPDateTimeUtil.java @@ -199,7 +199,7 @@ public final class SPDateTimeUtil { /** * */ - private CalendarI18N(final String single, final String plural) { + CalendarI18N(final String single, final String plural) { this.single = single; this.plural = plural; }