Fix visibility and unused properties

Signed-off-by: kaizimmerm <kai.zimmermann@bosch-si.com>
This commit is contained in:
kaizimmerm
2016-11-29 09:35:09 +01:00
parent 8fbacd44a2
commit 032230bdcf
65 changed files with 86 additions and 171 deletions

View File

@@ -54,7 +54,7 @@ public class UploadViewConfirmationWindowLayout extends AbstractConfirmationWind
private final ArtifactUploadState artifactUploadState;
public UploadViewConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus,
UploadViewConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus,
final SoftwareManagement softwareManagement, final ArtifactUploadState artifactUploadState) {
super(i18n, eventBus);
this.softwareManagement = softwareManagement;

View File

@@ -36,8 +36,6 @@ import com.vaadin.ui.Window;
/**
* Software module details.
*
*
*/
public class SoftwareModuleDetails extends AbstractNamedVersionedEntityTableDetailsLayout<SoftwareModule> {
@@ -53,8 +51,7 @@ public class SoftwareModuleDetails extends AbstractNamedVersionedEntityTableDeta
private final SoftwareModuleMetadatadetailslayout swmMetadataTable;
public SoftwareModuleDetails(final I18N i18n, final UIEventBus eventBus,
final SpPermissionChecker permissionChecker,
SoftwareModuleDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow,
final ArtifactUploadState artifactUploadState, final SoftwareManagement softwareManagement,
final SwMetadataPopupLayout swMetadataPopupLayout, final EntityFactory entityFactory) {

View File

@@ -65,7 +65,7 @@ public class SoftwareModuleTable extends AbstractNamedVersionTable<SoftwareModul
private final SwMetadataPopupLayout swMetadataPopupLayout;
public SoftwareModuleTable(final UIEventBus eventBus, final I18N i18n, final UINotification uiNotification,
SoftwareModuleTable(final UIEventBus eventBus, final I18N i18n, final UINotification uiNotification,
final ArtifactUploadState artifactUploadState, final SoftwareManagement softwareManagement,
final UploadViewAcceptCriteria uploadViewAcceptCriteria, final EntityFactory entityFactory,
final SpPermissionChecker permChecker, final SwMetadataPopupLayout swMetadataPopupLayout) {

View File

@@ -38,7 +38,7 @@ public class SoftwareModuleTableHeader extends AbstractTableHeader {
private final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow;
public SoftwareModuleTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
SoftwareModuleTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
final ArtifactUploadState artifactUploadState, final UINotification uiNotifcation,
final UIEventBus eventBus, final SoftwareManagement softwareManagement, final EntityFactory entityFactory,
final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow) {

View File

@@ -33,7 +33,7 @@ public class SMTypeFilterButtonClick extends AbstractFilterSingleButtonClick imp
private final transient SoftwareManagement softwareManagement;
public SMTypeFilterButtonClick(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState,
SMTypeFilterButtonClick(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState,
final SoftwareManagement softwareManagement) {
this.eventBus = eventBus;
this.artifactUploadState = artifactUploadState;

View File

@@ -42,7 +42,7 @@ public class SMTypeFilterButtons extends AbstractFilterButtons {
private final UploadViewAcceptCriteria uploadViewAcceptCriteria;
public SMTypeFilterButtons(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState,
SMTypeFilterButtons(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState,
final UploadViewAcceptCriteria uploadViewAcceptCriteria, final SoftwareManagement softwareManagement) {
super(eventBus, new SMTypeFilterButtonClick(eventBus, artifactUploadState, softwareManagement));
this.artifactUploadState = artifactUploadState;

View File

@@ -36,7 +36,7 @@ public class SMTypeFilterHeader extends AbstractFilterHeader {
private final ArtifactUploadState artifactUploadState;
private final CreateUpdateSoftwareTypeLayout createUpdateSWTypeLayout;
public SMTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
SMTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
final ArtifactUploadState artifactUploadState, final TagManagement tagManagement,
final EntityFactory entityFactory, final UINotification uiNotification,
final SoftwareManagement softwareManagement) {

View File

@@ -85,16 +85,6 @@ public class CustomFile implements Serializable {
this.baseSoftwareModuleVersion = baseSoftwareModuleVersion;
}
/**
* Default constructor with the immutable fileName set.
*
* @param fileName
* uploaded file name
*/
public CustomFile(final String fileName) {
this.fileName = fileName;
}
public String getBaseSoftwareModuleName() {
return baseSoftwareModuleName;
}

View File

@@ -124,8 +124,7 @@ public class UploadConfirmationWindow implements Button.ClickListener {
* @param artifactUploadState
* reference of session variable {@link ArtifactUploadState}.
*/
public UploadConfirmationWindow(final UploadLayout artifactUploadView,
final ArtifactUploadState artifactUploadState) {
UploadConfirmationWindow(final UploadLayout artifactUploadView, final ArtifactUploadState artifactUploadState) {
this.uploadLayout = artifactUploadView;
this.artifactUploadState = artifactUploadState;
i18n = artifactUploadView.getI18n();

View File

@@ -72,7 +72,7 @@ public class UploadResultWindow implements Button.ClickListener {
* @param i18n
* I18N
*/
public UploadResultWindow(final List<UploadStatus> uploadResultList, final I18N i18n) {
UploadResultWindow(final List<UploadStatus> uploadResultList, final I18N i18n) {
this.uploadResultList = uploadResultList;
this.i18n = i18n;
eventBus = SpringContextHelper.getBean(EventBus.UIEventBus.class);

View File

@@ -93,8 +93,7 @@ public class UploadStatusInfoWindow extends Window {
private ConfirmationDialog confirmDialog;
public UploadStatusInfoWindow(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState,
final I18N i18n) {
UploadStatusInfoWindow(final UIEventBus eventBus, final ArtifactUploadState artifactUploadState, final I18N i18n) {
this.eventBus = eventBus;
this.artifactUploadState = artifactUploadState;
this.i18n = i18n;

View File

@@ -27,15 +27,7 @@ public class UploadStatusObject implements Serializable {
private String reason;
private final SoftwareModule selectedSoftwareModule;
public UploadStatusObject(final String status, final Double progress, final String fileName, final String reason,
final SoftwareModule selectedSoftwareModule) {
this(fileName, selectedSoftwareModule);
this.status = status;
this.progress = progress;
this.reason = reason;
}
public UploadStatusObject(final String fileName, final SoftwareModule selectedSoftwareModule) {
UploadStatusObject(final String fileName, final SoftwareModule selectedSoftwareModule) {
this.filename = fileName;
this.selectedSoftwareModule = selectedSoftwareModule;
}

View File

@@ -62,7 +62,7 @@ public class ColorPickerLayout extends GridLayout {
addComponent(colorSelect, 1, 1, 1, 3);
}
public void init() {
private void init() {
selectors = new HashSet<>();
selectedColor = getDefaultColor();
@@ -80,7 +80,7 @@ public class ColorPickerLayout extends GridLayout {
selectors.add(colorSelect);
}
public Slider createRGBSlider(final String caption, final String styleName) {
private Slider createRGBSlider(final String caption, final String styleName) {
final Slider slider = new Slider(caption, 0, 255);
slider.setImmediate(true);
slider.setWidth("150px");

View File

@@ -19,9 +19,6 @@ import com.vaadin.ui.VerticalLayout;
/**
* Distribution set panel for Target.
*
*
*
*/
@SuppressWarnings("serial")
public class DistributionSetInfoPanel extends Panel {
@@ -38,9 +35,8 @@ public class DistributionSetInfoPanel extends Panel {
* @param style2
* as String
*/
public DistributionSetInfoPanel(final DistributionSet distributionSet, final String caption, final String style1,
DistributionSetInfoPanel(final DistributionSet distributionSet, final String caption, final String style1,
final String style2) {
super();
setImmediate(false);
decorate(distributionSet, caption, style1, style2);
}

View File

@@ -21,9 +21,6 @@ import com.vaadin.ui.VerticalLayout;
/**
* Attributes Vertical layout for Target.
*
*
*
*/
public class SPTargetAttributesLayout {
private final VerticalLayout targetAttributesLayout;
@@ -35,7 +32,7 @@ public class SPTargetAttributesLayout {
* controller attributes
*
*/
public SPTargetAttributesLayout(final Map<String, String> controllerAttibs) {
SPTargetAttributesLayout(final Map<String, String> controllerAttibs) {
targetAttributesLayout = new VerticalLayout();
targetAttributesLayout.setSpacing(true);
targetAttributesLayout.setMargin(true);

View File

@@ -13,29 +13,11 @@ import com.vaadin.ui.Button;
/**
* Basic button for SPUI. Any commonality can be decorated.
*
*
*
*/
public class SPUIButton extends Button {
/**
* ID.
*/
private static final long serialVersionUID = -7327726430436273739L;
/**
* Parametric constructor.
*
* @param id
* as String
* @param buttonName
* as String
* @param buttonDesc
* as String
*/
public SPUIButton(final String id, final String buttonName, final String buttonDesc) {
SPUIButton(final String id, final String buttonName, final String buttonDesc) {
super(buttonName);
setDescription(buttonDesc);
setImmediate(false);
@@ -50,7 +32,7 @@ public class SPUIButton extends Button {
* @param icon
* as Resource
*/
public void togleIcon(Resource icon) {
public void togleIcon(final Resource icon) {
setIcon(icon);
}
}

View File

@@ -13,32 +13,13 @@ import com.vaadin.ui.themes.ValoTheme;
/**
* ComboBox with required style.
*
*
*
*/
public class SPUICheckBox extends CheckBox {
private static final long serialVersionUID = 2270323611612189225L;
/**
* Parametric constructor to decorate.
*
* @param caption
* as caption for checkbox
* @param style
* style of the CheckBox
* @param styleName
* styleName of the CheckBox
* @param required
* required check for Checkbox
* @param data
* data of the CheckBox
*
*/
public SPUICheckBox(final String caption, final String style, final String styleName, final boolean required,
SPUICheckBox(final String caption, final String style, final String styleName, final boolean required,
final String data) {
super();
decorate(caption, style, styleName, required, data);
}

View File

@@ -33,7 +33,7 @@ public class DSTypeFilterButtonClick extends AbstractFilterSingleButtonClick imp
private final DistributionSetManagement distributionSetManagement;
public DSTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
DSTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
final DistributionSetManagement distributionSetManagement) {
this.eventBus = eventBus;
this.manageDistUIState = manageDistUIState;

View File

@@ -39,7 +39,7 @@ public class DSTypeFilterButtons extends AbstractFilterButtons {
private final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria;
public DSTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
DSTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria,
final DistributionSetManagement distributionSetManagement) {
super(eventBus, new DSTypeFilterButtonClick(eventBus, manageDistUIState, distributionSetManagement));

View File

@@ -37,7 +37,7 @@ public class DSTypeFilterHeader extends AbstractFilterHeader {
private final CreateUpdateDistSetTypeLayout createUpdateDistSetTypeLayout;
public DSTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
DSTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
final ManageDistUIState manageDistUIState, final TagManagement tagManagement,
final EntityFactory entityFactory, final UINotification uiNotification,
final SoftwareManagement softwareManagement, final DistributionSetManagement distributionSetManagement) {

View File

@@ -71,16 +71,14 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet
private final DistributionTagToken distributionTagToken;
private final SoftwareManagement softwareManagement;
private final transient SoftwareManagement softwareManagement;
private final DistributionSetManagement distributionSetManagement;
private final transient DistributionSetManagement distributionSetManagement;
private final TargetManagement targetManagement;
private final transient TargetManagement targetManagement;
private final DsMetadataPopupLayout dsMetadataPopupLayout;
private final EntityFactory entityFactory;
private final SoftwareModuleDetailsTable softwareModuleTable;
private final DistributionSetMetadatadetailslayout dsMetadataTable;
@@ -91,9 +89,8 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet
private Map<String, StringBuilder> assignedSWModule;
public DistributionSetDetails(final I18N i18n, final UIEventBus eventBus,
final SpPermissionChecker permissionChecker, final ManageDistUIState manageDistUIState,
final ManagementUIState managementUIState,
DistributionSetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
final ManageDistUIState manageDistUIState, final ManagementUIState managementUIState,
final DistributionAddUpdateWindowLayout distributionAddUpdateWindowLayout,
final SoftwareManagement softwareManagement, final DistributionSetManagement distributionSetManagement,
final TargetManagement targetManagement, final EntityFactory entityFactory,
@@ -108,7 +105,6 @@ public class DistributionSetDetails extends AbstractNamedVersionedEntityTableDet
this.distributionSetManagement = distributionSetManagement;
this.targetManagement = targetManagement;
this.dsMetadataPopupLayout = popupLayout;
this.entityFactory = entityFactory;
softwareModuleTable = new SoftwareModuleDetailsTable(i18n, true, permissionChecker, distributionSetManagement,
eventBus, manageDistUIState);

View File

@@ -98,7 +98,7 @@ public class DistributionSetTable extends AbstractNamedVersionTable<Distribution
private final DsMetadataPopupLayout dsMetadataPopupLayout;
public DistributionSetTable(final UIEventBus eventBus, final I18N i18n, final UINotification notification,
DistributionSetTable(final UIEventBus eventBus, final I18N i18n, final UINotification notification,
final SpPermissionChecker permissionChecker, final ManageDistUIState manageDistUIState,
final DistributionSetManagement distributionSetManagement, final SoftwareManagement softwareManagement,
final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria,

View File

@@ -37,7 +37,7 @@ public class DistributionSetTableHeader extends AbstractTableHeader {
private final DistributionAddUpdateWindowLayout addUpdateWindowLayout;
public DistributionSetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
DistributionSetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
final ManageDistUIState manageDistUIstate, final DistributionAddUpdateWindowLayout addUpdateWindowLayout) {
super(i18n, permChecker, eventbus, null, manageDistUIstate, null);
this.addUpdateWindowLayout = addUpdateWindowLayout;

View File

@@ -79,7 +79,7 @@ public class DistributionsConfirmationWindowLayout extends AbstractConfirmationW
private final ManageDistUIState manageDistUIState;
public DistributionsConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus,
DistributionsConfirmationWindowLayout(final I18N i18n, final UIEventBus eventBus,
final DistributionSetManagement dsManagement, final SoftwareManagement softwareManagement,
final ManageDistUIState manageDistUIState) {
super(i18n, eventBus);

View File

@@ -52,7 +52,7 @@ public class SwModuleDetails extends AbstractNamedVersionedEntityTableDetailsLay
private final SoftwareModuleMetadatadetailslayout swmMetadataTable;
public SwModuleDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
SwModuleDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow,
final ManageDistUIState manageDistUIState, final SoftwareManagement softwareManagement,
final SwMetadataPopupLayout swMetadataPopupLayout, final EntityFactory entityFactory) {

View File

@@ -75,7 +75,7 @@ public class SwModuleTable extends AbstractNamedVersionTable<SoftwareModule, Lon
private final SwMetadataPopupLayout swMetadataPopupLayout;
public SwModuleTable(final UIEventBus eventBus, final I18N i18n, final UINotification uiNotification,
SwModuleTable(final UIEventBus eventBus, final I18N i18n, final UINotification uiNotification,
final ManageDistUIState manageDistUIState, final SoftwareManagement softwareManagement,
final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria,
final SwMetadataPopupLayout swMetadataPopupLayout, final ArtifactUploadState artifactUploadState) {

View File

@@ -37,7 +37,7 @@ public class SwModuleTableHeader extends AbstractTableHeader {
private final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow;
public SwModuleTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
SwModuleTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
final ManageDistUIState manageDistUIstate,
final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow) {
super(i18n, permChecker, eventbus, null, manageDistUIstate, null);

View File

@@ -33,7 +33,7 @@ public class DistSMTypeFilterButtonClick extends AbstractFilterSingleButtonClick
private final transient SoftwareManagement softwareManagement;
public DistSMTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
DistSMTypeFilterButtonClick(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
final SoftwareManagement softwareManagement) {
this.eventBus = eventBus;
this.manageDistUIState = manageDistUIState;

View File

@@ -46,7 +46,7 @@ public class DistSMTypeFilterButtons extends AbstractFilterButtons {
private final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria;
public DistSMTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
DistSMTypeFilterButtons(final UIEventBus eventBus, final ManageDistUIState manageDistUIState,
final DistributionsViewAcceptCriteria distributionsViewAcceptCriteria,
final SoftwareManagement softwareManagement) {
super(eventBus, new DistSMTypeFilterButtonClick(eventBus, manageDistUIState, softwareManagement));

View File

@@ -36,7 +36,7 @@ public class DistSMTypeFilterHeader extends AbstractFilterHeader {
private final ManageDistUIState manageDistUIState;
private final CreateUpdateSoftwareTypeLayout createUpdateSWTypeLayout;
public DistSMTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
DistSMTypeFilterHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus,
final ManageDistUIState manageDistUIState, final TagManagement tagManagement,
final EntityFactory entityFactory, final UINotification uiNotification,
final SoftwareManagement swTypeManagementService) {

View File

@@ -223,7 +223,7 @@ public class AutoCompleteTextFieldComponent extends HorizontalLayout {
class StatusCircledAsync implements Runnable {
private final UI current;
public StatusCircledAsync(final UI current) {
StatusCircledAsync(final UI current) {
this.current = current;
}

View File

@@ -105,7 +105,7 @@ public class CreateOrUpdateFilterHeader extends VerticalLayout implements Button
private LayoutClickListener nameLayoutClickListner;
public CreateOrUpdateFilterHeader(final I18N i18n, final UIEventBus eventBus,
CreateOrUpdateFilterHeader(final I18N i18n, final UIEventBus eventBus,
final FilterManagementUIState filterManagementUIState,
final TargetFilterQueryManagement targetFilterQueryManagement, final SpPermissionChecker permissionChecker,
final UINotification notification, final UiProperties uiProperties, final EntityFactory entityFactory,

View File

@@ -66,7 +66,7 @@ public class CreateOrUpdateFilterTable extends Table {
private static final String INSTALL_DIST_SET = "installedDistributionSet";
public CreateOrUpdateFilterTable(final I18N i18n, final UIEventBus eventBus,
CreateOrUpdateFilterTable(final I18N i18n, final UIEventBus eventBus,
final FilterManagementUIState filterManagementUIState) {
this.i18n = i18n;
this.filterManagementUIState = filterManagementUIState;

View File

@@ -46,8 +46,7 @@ public class DistributionSetSelectTable extends Table {
private Container container;
public DistributionSetSelectTable(final I18N i18n, final UIEventBus eventBus,
final ManageDistUIState manageDistUIState) {
DistributionSetSelectTable(final I18N i18n, final UIEventBus eventBus, final ManageDistUIState manageDistUIState) {
this.i18n = i18n;
this.manageDistUIState = manageDistUIState;
setStyleName("sp-table");

View File

@@ -62,9 +62,8 @@ public class DistributionSetSelectWindow
private CheckBox checkBox;
private Long tfqId;
public DistributionSetSelectWindow(final I18N i18n, final UIEventBus eventBus,
final TargetManagement targetManagement, final TargetFilterQueryManagement targetFilterQueryManagement,
final ManageDistUIState manageDistUIState) {
DistributionSetSelectWindow(final I18N i18n, final UIEventBus eventBus, final TargetManagement targetManagement,
final TargetFilterQueryManagement targetFilterQueryManagement, final ManageDistUIState manageDistUIState) {
this.i18n = i18n;
this.dsTable = new DistributionSetSelectTable(i18n, eventBus, manageDistUIState);
this.eventBus = eventBus;

View File

@@ -40,7 +40,7 @@ public class ActionHistoryHeader extends VerticalLayout {
private Label titleOfActionHistory;
private SPUIButton maxMinButton;
public ActionHistoryHeader(final UIEventBus eventBus, final ManagementUIState managementUIState) {
ActionHistoryHeader(final UIEventBus eventBus, final ManagementUIState managementUIState) {
this.eventBus = eventBus;
this.managementUIState = managementUIState;
buildComponent();

View File

@@ -85,8 +85,8 @@ public class ActionHistoryTable extends TreeTable {
private Target target;
public ActionHistoryTable(final I18N i18n, final DeploymentManagement deploymentManagement,
final UIEventBus eventBus, final UINotification notification, final ManagementUIState managementUIState) {
ActionHistoryTable(final I18N i18n, final DeploymentManagement deploymentManagement, final UIEventBus eventBus,
final UINotification notification, final ManagementUIState managementUIState) {
this.i18n = i18n;
this.deploymentManagement = deploymentManagement;
this.eventBus = eventBus;

View File

@@ -48,13 +48,12 @@ public class DistributionDetails extends AbstractNamedVersionedEntityTableDetail
private final DistributionTagToken distributionTagToken;
private final DistributionSetManagement distributionSetManagement;
private final DsMetadataPopupLayout dsMetadataPopupLayout;
private final EntityFactory entityFactory;
private final SoftwareModuleDetailsTable softwareModuleTable;
private final DistributionSetMetadatadetailslayout dsMetadataTable;
public DistributionDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
DistributionDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
final ManagementUIState managementUIState, final DistributionSetManagement distributionSetManagement,
final DsMetadataPopupLayout dsMetadataPopupLayout, final EntityFactory entityFactory,
final UINotification notificationMessage, final SystemManagement systemManagement,
@@ -67,7 +66,6 @@ public class DistributionDetails extends AbstractNamedVersionedEntityTableDetail
this.distributionSetManagement = distributionSetManagement;
this.dsMetadataPopupLayout = new DsMetadataPopupLayout(i18n, notificationMessage, eventBus,
distributionSetManagement, entityFactory, permissionChecker);
this.entityFactory = entityFactory;
this.distributionAddUpdateWindowLayout = distributionAddUpdateWindowLayout;
softwareModuleTable = new SoftwareModuleDetailsTable(i18n, false, permissionChecker, null, null, null);

View File

@@ -90,7 +90,7 @@ public class DistributionTable extends AbstractNamedVersionTable<DistributionSet
private boolean isDistPinned;
private Button distributinPinnedBtn;
public DistributionTable(final UIEventBus eventBus, final I18N i18n, final SpPermissionChecker permissionChecker,
DistributionTable(final UIEventBus eventBus, final I18N i18n, final SpPermissionChecker permissionChecker,
final UINotification notification, final ManagementUIState managementUIState,
final ManagementViewAcceptCriteria managementViewAcceptCriteria, final TargetManagement targetService,
final DsMetadataPopupLayout dsMetadataPopupLayout,

View File

@@ -36,7 +36,7 @@ public class DistributionTableHeader extends AbstractTableHeader {
private final DistributionAddUpdateWindowLayout distributionAddUpdateWindowLayout;
public DistributionTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
DistributionTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
final ManagementUIState managementUIState,
final DistributionAddUpdateWindowLayout distributionAddUpdateWindowLayout) {
super(i18n, permChecker, eventbus, managementUIState, null, null);

View File

@@ -42,7 +42,7 @@ public class CreateUpdateDistributionTagLayoutWindow extends AbstractCreateUpdat
private static final String TARGET_TAG_NAME_DYNAMIC_STYLE = "new-target-tag-name";
private static final String MSG_TEXTFIELD_NAME = "textfield.name";
public CreateUpdateDistributionTagLayoutWindow(final I18N i18n, final TagManagement tagManagement,
CreateUpdateDistributionTagLayoutWindow(final I18N i18n, final TagManagement tagManagement,
final EntityFactory entityFactory, final UIEventBus eventBus, final SpPermissionChecker permChecker,
final UINotification uiNotification) {
super(i18n, tagManagement, entityFactory, eventBus, permChecker, uiNotification);

View File

@@ -27,7 +27,7 @@ public class DistributionTagButtonClick extends AbstractFilterMultiButtonClick {
private final transient EventBus.UIEventBus eventBus;
private final ManagementUIState managementUIState;
public DistributionTagButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) {
DistributionTagButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) {
this.eventBus = eventBus;
this.managementUIState = managementUIState;
}

View File

@@ -54,7 +54,7 @@ public class DistributionTagButtons extends AbstractFilterButtons {
private final ManagementUIState managementUIState;
private final EntityFactory entityFactory;
public DistributionTagButtons(final UIEventBus eventBus, final ManagementUIState managementUIState,
DistributionTagButtons(final UIEventBus eventBus, final ManagementUIState managementUIState,
final EntityFactory entityFactory, final I18N i18n, final UINotification notification,
final SpPermissionChecker permChecker, final DistributionTableFilters distFilterParameters,
final DistributionSetManagement distributionSetManagement,

View File

@@ -34,7 +34,7 @@ public class DistributionTagHeader extends AbstractFilterHeader {
private final ManagementUIState managementUIState;
private final CreateUpdateDistributionTagLayoutWindow createORUpdateDistributionTagLayout;
public DistributionTagHeader(final I18N i18n, final ManagementUIState managementUIState,
DistributionTagHeader(final I18N i18n, final ManagementUIState managementUIState,
final SpPermissionChecker permChecker, final UIEventBus eventBus, final TagManagement tagManagement,
final EntityFactory entityFactory, final UINotification uiNotification) {
super(permChecker, eventBus, i18n);

View File

@@ -100,7 +100,7 @@ public class BulkUploadHandler extends CustomComponent
private transient EntityFactory entityFactory;
private final UI uiInstance;
public BulkUploadHandler(final TargetBulkUpdateWindowLayout targetBulkUpdateWindowLayout,
BulkUploadHandler(final TargetBulkUpdateWindowLayout targetBulkUpdateWindowLayout,
final TargetManagement targetManagement, final ManagementUIState managementUIState,
final DeploymentManagement deploymentManagement, final I18N i18n, final UI uiInstance) {
this.uiInstance = uiInstance;
@@ -172,7 +172,7 @@ public class BulkUploadHandler extends CustomComponent
*
* @param event
*/
public UploadAsync(final SucceededEvent event) {
private UploadAsync(final SucceededEvent event) {
this.event = event;
}

View File

@@ -64,8 +64,8 @@ public class TargetAddUpdateWindowLayout extends CustomComponent {
private FormLayout formLayout;
private CommonDialogWindow window;
public TargetAddUpdateWindowLayout(final I18N i18n, final TargetManagement targetManagement,
final UIEventBus eventBus, final UINotification uINotification, final EntityFactory entityFactory) {
TargetAddUpdateWindowLayout(final I18N i18n, final TargetManagement targetManagement, final UIEventBus eventBus,
final UINotification uINotification, final EntityFactory entityFactory) {
this.i18n = i18n;
this.targetManagement = targetManagement;
this.eventBus = eventBus;

View File

@@ -26,7 +26,7 @@ import org.vaadin.spring.events.EventBus.UIEventBus;
public class TargetBulkTokenTags extends AbstractTargetTagToken {
private static final long serialVersionUID = 4159616629565523717L;
public TargetBulkTokenTags(final SpPermissionChecker checker, final I18N i18n, final UINotification uinotification,
TargetBulkTokenTags(final SpPermissionChecker checker, final I18N i18n, final UINotification uinotification,
final UIEventBus eventBus, final ManagementUIState managementUIState, final TagManagement tagManagement) {
super(checker, i18n, uinotification, eventBus, managementUIState, tagManagement);
}

View File

@@ -90,10 +90,10 @@ public class TargetBulkUpdateWindowLayout extends CustomComponent {
private Button minimizeButton;
private Button closeButton;
public TargetBulkUpdateWindowLayout(final I18N i18n, final TargetManagement targetManagement,
final UIEventBus eventBus, final ManagementUIState managementUIState,
final DeploymentManagement deploymentManagement, final UiProperties uiproperties,
final SpPermissionChecker checker, final UINotification uinotification, final TagManagement tagManagement) {
TargetBulkUpdateWindowLayout(final I18N i18n, final TargetManagement targetManagement, final UIEventBus eventBus,
final ManagementUIState managementUIState, final DeploymentManagement deploymentManagement,
final UiProperties uiproperties, final SpPermissionChecker checker, final UINotification uinotification,
final TagManagement tagManagement) {
this.i18n = i18n;
this.targetManagement = targetManagement;
this.eventBus = eventBus;

View File

@@ -59,7 +59,7 @@ public class TargetDetails extends AbstractTableDetailsLayout<Target> {
private VerticalLayout assignedDistLayout;
private VerticalLayout installedDistLayout;
public TargetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
TargetDetails(final I18N i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker,
final ManagementUIState managementUIState, final UINotification uiNotification,
final TagManagement tagManagement, final TargetManagement targetManagement,
final EntityFactory entityFactory) {

View File

@@ -71,7 +71,7 @@ public class TargetTableHeader extends AbstractTableHeader {
private boolean isComplexFilterViewDisplayed;
public TargetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
TargetTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus,
final UINotification notification, final ManagementUIState managementUIState,
final ManagementViewAcceptCriteria managementViewAcceptCriteria, final TargetManagement targetManagement,
final DeploymentManagement deploymentManagement, final UiProperties uiproperties, final UIEventBus eventBus,

View File

@@ -61,7 +61,7 @@ public class FilterByStatusLayout extends VerticalLayout implements Button.Click
private Button buttonClicked;
private static final String BTN_CLICKED = "btnClicked";
public FilterByStatusLayout(final I18N i18n, final UIEventBus eventBus, final ManagementUIState managementUIState) {
FilterByStatusLayout(final I18N i18n, final UIEventBus eventBus, final ManagementUIState managementUIState) {
this.i18n = i18n;
this.eventBus = eventBus;
this.managementUIState = managementUIState;

View File

@@ -56,7 +56,7 @@ public class MultipleTargetFilter extends Accordion implements SelectedTabChange
private Button config;
public MultipleTargetFilter(final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout,
MultipleTargetFilter(final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout,
final SpPermissionChecker permChecker, final ManagementUIState managementUIState, final I18N i18n,
final UIEventBus eventBus, final ManagementViewAcceptCriteria managementViewAcceptCriteria,
final UINotification notification, final EntityFactory entityFactory,

View File

@@ -46,7 +46,7 @@ public class TargetFilterQueryButtons extends Table {
private CustomTargetTagFilterButtonClick customTargetTagFilterButtonClick;
public TargetFilterQueryButtons(final ManagementUIState managementUIState, final UIEventBus eventBus) {
TargetFilterQueryButtons(final ManagementUIState managementUIState, final UIEventBus eventBus) {
this.managementUIState = managementUIState;
this.eventBus = eventBus;
}
@@ -56,7 +56,7 @@ public class TargetFilterQueryButtons extends Table {
*
* @param filterButtonClickBehaviour
*/
public void init(final CustomTargetTagFilterButtonClick filterButtonClickBehaviour) {
void init(final CustomTargetTagFilterButtonClick filterButtonClickBehaviour) {
this.customTargetTagFilterButtonClick = filterButtonClickBehaviour;
createTable();
eventBus.subscribe(this);

View File

@@ -31,7 +31,7 @@ public class TargetTagFilterButtonClick extends AbstractFilterMultiButtonClick i
private final ManagementUIState managementUIState;
public TargetTagFilterButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) {
TargetTagFilterButtonClick(final UIEventBus eventBus, final ManagementUIState managementUIState) {
this.eventBus = eventBus;
this.managementUIState = managementUIState;
}

View File

@@ -73,7 +73,7 @@ public class TargetTagFilterButtons extends AbstractFilterButtons {
private final TargetManagement targetManagement;
public TargetTagFilterButtons(final UIEventBus eventBus, final ManagementUIState managementUIState,
TargetTagFilterButtons(final UIEventBus eventBus, final ManagementUIState managementUIState,
final ManagementViewAcceptCriteria managementViewAcceptCriteria, final I18N i18n,
final UINotification notification, final SpPermissionChecker permChecker, final EntityFactory entityFactory,
final TargetManagement targetManagement) {

View File

@@ -26,14 +26,12 @@ public class TargetTagFilterHeader extends AbstractFilterHeader {
private static final long serialVersionUID = 3046367045669148009L;
private final ManagementUIState managementUIState;
private final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout;
public TargetTagFilterHeader(final I18N i18n, final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout,
TargetTagFilterHeader(final I18N i18n, final CreateUpdateTargetTagLayoutWindow createUpdateTargetTagLayout,
final ManagementUIState managementUIState, final SpPermissionChecker permChecker,
final UIEventBus eventBus) {
super(permChecker, eventBus, i18n);
this.managementUIState = managementUIState;
this.createUpdateTargetTagLayout = createUpdateTargetTagLayout;
if (permChecker.hasCreateTargetPermission() || permChecker.hasUpdateTargetPermission()) {
createUpdateTargetTagLayout.init();
}

View File

@@ -24,14 +24,14 @@ public class GravatarResource extends ExternalResource {
/**
* Construct based on given email address. Generates external resource
* pointing to gravatar with rating
* "g: suitable for display on all websites with any audience type." and
* "mystery-man" icon as backup as secure request.
* pointing to gravatar with rating "g: suitable for display on all websites
* with any audience type." and "mystery-man" icon as backup as secure
* request.
*
* @param email
* to generate resource for
*/
public GravatarResource(final String email) {
GravatarResource(final String email) {
super("https://www.gravatar.com/avatar/" + DigestUtils.md5DigestAsHex(email.getBytes()) + ".jpg?s=56&r=g&d=mm");
}

View File

@@ -25,7 +25,7 @@ public class StatusFontIcon {
final FontAwesome fontIcon;
final String style;
public StatusFontIcon(FontAwesome fontIcon, String style) {
public StatusFontIcon(final FontAwesome fontIcon, final String style) {
super();
this.fontIcon = fontIcon;
this.style = style;
@@ -39,4 +39,4 @@ public class StatusFontIcon {
return style;
}
}
}

View File

@@ -128,10 +128,9 @@ public class AddUpdateRolloutWindowLayout extends GridLayout {
private final NullValidator nullValidator = new NullValidator(null, false);
public AddUpdateRolloutWindowLayout(final RolloutManagement rolloutManagement,
final TargetManagement targetManagement, final UINotification uiNotification,
final UiProperties uiProperties, final EntityFactory entityFactory, final I18N i18n,
final UIEventBus eventBus) {
AddUpdateRolloutWindowLayout(final RolloutManagement rolloutManagement, final TargetManagement targetManagement,
final UINotification uiNotification, final UiProperties uiProperties, final EntityFactory entityFactory,
final I18N i18n, final UIEventBus eventBus) {
this.actionTypeOptionGroupLayout = new ActionTypeOptionGroupLayout(i18n);
this.rolloutManagement = rolloutManagement;
this.targetManagement = targetManagement;

View File

@@ -127,7 +127,7 @@ public class RolloutListGrid extends AbstractGrid {
new StatusFontIcon(FontAwesome.EXCLAMATION_CIRCLE, SPUIStyleDefinitions.STATUS_ICON_RED));
}
public RolloutListGrid(final I18N i18n, final UIEventBus eventBus, final RolloutManagement rolloutManagement,
RolloutListGrid(final I18N i18n, final UIEventBus eventBus, final RolloutManagement rolloutManagement,
final UINotification uiNotification, final RolloutUIState rolloutUIState,
final SpPermissionChecker permissionChecker, final TargetManagement targetManagement,
final EntityFactory entityFactory, final UiProperties uiProperties) {

View File

@@ -40,7 +40,7 @@ public class RolloutListHeader extends AbstractGridHeader {
private final AddUpdateRolloutWindowLayout addUpdateRolloutWindow;
public RolloutListHeader(final SpPermissionChecker permissionChecker, final RolloutUIState rolloutUIState,
RolloutListHeader(final SpPermissionChecker permissionChecker, final RolloutUIState rolloutUIState,
final UIEventBus eventBus, final RolloutManagement rolloutManagement,
final TargetManagement targetManagement, final UINotification uiNotification,
final UiProperties uiProperties, final EntityFactory entityFactory, final I18N i18n) {

View File

@@ -55,8 +55,7 @@ public class AuthenticationConfigurationView extends BaseConfigurationView
private CheckBox downloadAnonymousCheckBox;
public AuthenticationConfigurationView(final I18N i18n,
final TenantConfigurationManagement tenantConfigurationManagement,
AuthenticationConfigurationView(final I18N i18n, final TenantConfigurationManagement tenantConfigurationManagement,
final SecurityTokenGenerator securityTokenGenerator) {
this.i18n = i18n;
this.certificateAuthenticationConfigurationItem = new CertificateAuthenticationConfigurationItem(

View File

@@ -33,11 +33,7 @@ public class DefaultDistributionSetTypeLayout extends BaseConfigurationView impl
private static final long serialVersionUID = 17896542758L;
private final SystemManagement systemManagement;
private final DistributionSetManagement distributionSetManagement;
private final I18N i18n;
private final transient SystemManagement systemManagement;
private Long currentDefaultDisSetType;
@@ -49,11 +45,9 @@ public class DefaultDistributionSetTypeLayout extends BaseConfigurationView impl
private final Label changeIcon;
public DefaultDistributionSetTypeLayout(final SystemManagement systemManagement,
DefaultDistributionSetTypeLayout(final SystemManagement systemManagement,
final DistributionSetManagement distributionSetManagement, final I18N i18n) {
this.systemManagement = systemManagement;
this.distributionSetManagement = distributionSetManagement;
this.i18n = i18n;
final Panel rootPanel = new Panel();
rootPanel.setSizeFull();

View File

@@ -38,7 +38,7 @@ public class PollingConfigurationView extends BaseConfigurationView
private Duration tenantPollTime;
private Duration tenantOverdueTime;
public PollingConfigurationView(final I18N i18n, final ControllerPollProperties controllerPollProperties,
PollingConfigurationView(final I18N i18n, final ControllerPollProperties controllerPollProperties,
final TenantConfigurationManagement tenantConfigurationManagement) {
this.tenantConfigurationManagement = tenantConfigurationManagement;
@@ -130,7 +130,7 @@ public class PollingConfigurationView extends BaseConfigurationView
notifyConfigurationChanged();
}
private boolean compareDurations(final Duration d1, final Duration d2) {
private static boolean compareDurations(final Duration d1, final Duration d2) {
if (d1 == null && d2 == null) {
return true;
}

View File

@@ -199,7 +199,7 @@ public final class SPDateTimeUtil {
/**
*
*/
private CalendarI18N(final String single, final String plural) {
CalendarI18N(final String single, final String plural) {
this.single = single;
this.plural = plural;
}